crypto: gcm - wait for crypto op not signal safe
authorGilad Ben-Yossef <gilad@benyossef.com>
Thu, 18 May 2017 13:29:25 +0000 (16:29 +0300)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 23 Jul 2017 02:54:47 +0000 (02:54 +0000)
commit12c075565cdbbcd8c4ceec297c1325cbb0803073
tree3040ff5a93e2e8a4988e069b8aae5f6676b7acf5
parent4f16ec4ead4b0314436160ff32a0f3469412671e
crypto: gcm - wait for crypto op not signal safe

commit f3ad587070d6bd961ab942b3fd7a85d00dfc934b upstream.

crypto_gcm_setkey() was using wait_for_completion_interruptible() to
wait for completion of async crypto op but if a signal occurs it
may return before DMA ops of HW crypto provider finish, thus
corrupting the data buffer that is kfree'ed in this case.

Resolve this by using wait_for_completion() instead.

Reported-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/gcm.c